[Imc-oceania] Re: [Catgeek] small hack on drupal install to get sydney imc syndicated to imc-oceania site

Andrew McNaughton andrew at scoop.co.nz
Sun Apr 9 04:03:32 UTC 2006


Ugly hack - don't do that.  Do not change the drupal core.  Along with 
maintenance headaches, This affects multiple sites and changes should not 
be made to the drupal core without prior discussion, and probably not at 
all.

If the standard node type can't be made to do what you want, make a new 
node type.  Probably the standard node type can do what you want, but it 
takes a little longer to figure out how that should be done.

In terms of your (reversed) patch, dc:date should be compatible with 
http://www.w3.org/TR/NOTE-datetime (eg 2006-04-098T12:50:00+10:00), and it 
conflicts with the pubDate field.  Some feed readers are presumably going 
to decide to use the dc:date field and then get confused.  I think that's 
enough reason to back out the change, but I haven't done so just yet.  It 
can wait till you figure out how to do this without changing the drupal 
core.

In the process of checking a validator, I found out we also have an issue 
relating to relative URLs in the description due to Michael's image 
insertion code.  I'll chase that up.

Andrew



On Sun, 9 Apr 2006, andy at cat.org.au wrote:

> hi
> i made a small hack to sydney's feature feed syndicated properly onto
> imc-oceania site
> the rss output should be backwards compatible so hopefully other sites
> sharing this code arent affected.
>
> sydneys features are now on oceania ;)
>
> andy
>
> patch follows
>
> andy at kahlo:/usr/local/drupal-4.6.6/modules$ diff node.module
> node.module.backup
> 1159d1158
> <     $extra = array_merge($extra, array(array('key' => 'dc:date',
> 'value' =>  date('r', $item->created))));
> 1174c1173
> <   $output .= "<rss version=\"". $channel["version"] . "\"
> xml:base=\"". $base_url ."\"
> xmlns:dc=\"http://purl.org/dc/elements/1.1/\">\n";
> ---
>>   $output .= "<rss version=\"". $channel["version"] . "\"
>>   xml:base=\"". $base_url ."\">\n";
>
>
> as you can see the original node.module is in a file
> node.module.backup, if you need to revert
> _______________________________________________
> Catgeek mailing list
> Catgeek at lists.cat.org.au
> http://lists.cat.org.au/mailman/listinfo/catgeek
>

-------------------------------------------------------------------
Andrew McNaughton           http://www.scoop.co.nz/
andrew at scoop.co.nz          Mobile: +61 422 753 792
                             pgp keyid: 1C7A8CFD
--
"We are trying to figure out how you conduct a war against something
other than a nation-state and how ... you conduct a war in countries
that you are not at war with,"   -- Donald Rumsfeld, 27 Jan 2006



More information about the Imc-oceania mailing list